tests: kernel: timer: timer_behavior: Fix max_stddev calculation #93325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max_stddev calculation was previously patched to be more at least 1 system clock cycle to cover for platforms that use higher frequency system clock (32kHz). On that platform (nRF52) system clock frequency was the same as tick frequency but on nRF54x that is no longer true. Initially, the intention was to use 1 system tick and not cycle. Fixing it now. Signed-off-by: Krzysztof Chruściński <[email protected]>
zephyrbot
requested review from
TaiJuWu,
andyross,
ceolin,
cfriedt,
dcpleung,
nashif,
npitre and
peter-mitsis
nordic-segl
approved these changes
Jul 18, 2025
|
kl-cruz
approved these changes
Jul 18, 2025
peter-mitsis
approved these changes
Jul 18, 2025
dcpleung
approved these changes
Jul 18, 2025
cfriedt
approved these changes
Jul 19, 2025
TaiJuWu
approved these changes
Jul 19, 2025
|
It is good for adding which previous commit to fix platform issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max_stddev calculation was previously patched to be more at least 1 system clock cycle to cover for platforms that use higher frequency system clock (32kHz). On that platform (nRF52) system clock frequency was the same as tick frequency but on nRF54x that is no longer true. Initially, the intention was to use 1 system tick and not cycle. Fixing it now.